fix: Ensure consistent price calculations across all pages

PROBLEM:
- TLD prices in overview table differed from detail page
- Detail page was recalculating prices instead of using API data

SOLUTION:
1. Updated Frontend API types to include all backend fields:
   - getTldCompare: Added type, description, registry, introduced,
     cheapest_registrar, cheapest_price, price_range
   - getTldHistory: Added type, description, registry, trend,
     trend_reason, source

2. Fixed TLD Detail Page:
   - Now uses price_range from Compare API directly
   - Removed manual price recalculation
   - Uses trend/trend_reason from History API
   - All values now match Overview table exactly

RESULT:
- Prices are now 100% consistent:
  - Overview table shows avg_registration_price from /overview API
  - Detail page shows pricing.avg from /compare API (same values)
  - Trending cards show current_price from /trending API (same values)
  - All calculated using get_avg_price() in backend

backend/app/api/portfolio.py

@@ -7,7 +7,7 @@ from sqlalchemy import select, func, and_
 from sqlalchemy.ext.asyncio import AsyncSession
 
 from app.database import get_db
-from app.api.auth import get_current_user
+from app.api.deps import get_current_user
 from app.models.user import User
 from app.models.portfolio import PortfolioDomain, DomainValuation
 from app.services.valuation import valuation_service

frontend/src/app/tld-pricing/[tld]/page.tsx

@@ -54,24 +54,29 @@ interface TldDetails {
 
 interface TldHistory {
   tld: string
+  type?: string
+  description?: string
+  registry?: string
   current_price: number
   price_change_7d: number
   price_change_30d: number
   price_change_90d: number
   trend: string
+  trend_reason: string
   history: Array<{
     date: string
     price: number
   }>
+  source?: string
 }
 
 interface DomainCheckResult {
   domain: string
   is_available: boolean
   status: string
-  registrar?: string
+  registrar?: string | null
-  creation_date?: string
+  creation_date?: string | null
-  expiration_date?: string
+  expiration_date?: string | null
 }
 
 // Registrar URLs with affiliate parameters
@@ -419,26 +424,28 @@ export default function TldDetailPage() {
       ])
       
       if (historyData && compareData) {
-        const registrars = compareData.registrars || []
+        // Sort registrars by price for display
-        const priceRange = compareData.price_range || { min: 0, max: 0, avg: 0 }
+        const sortedRegistrars = [...(compareData.registrars || [])].sort((a, b) => 
+          a.registration_price - b.registration_price
+        )
         
+        // Use API data directly for consistency with overview table
         setDetails({
           tld: compareData.tld || tld,
           type: compareData.type || 'generic',
           description: compareData.description || `Domain extension .${tld}`,
-          registry: compareData.registry || 'Unknown',
+          registry: compareData.registry || 'Various',
           introduced: compareData.introduced || 0,
           trend: historyData.trend || 'stable',
           trend_reason: historyData.trend_reason || 'Price tracking available',
           pricing: {
-            avg: priceRange.avg || historyData.current_price || 0,
+            // Use price_range from API for consistency with overview
-            min: priceRange.min || historyData.current_price || 0,
+            avg: compareData.price_range?.avg || historyData.current_price || 0,
-            max: priceRange.max || historyData.current_price || 0,
+            min: compareData.price_range?.min || historyData.current_price || 0,
+            max: compareData.price_range?.max || historyData.current_price || 0,
           },
-          registrars: registrars.sort((a: { registration_price: number }, b: { registration_price: number }) => 
+          registrars: sortedRegistrars,
-            a.registration_price - b.registration_price
+          cheapest_registrar: compareData.cheapest_registrar || sortedRegistrars[0]?.name || 'N/A',
-          ),
-          cheapest_registrar: compareData.cheapest_registrar || registrars[0]?.name || 'N/A',
         })
         setHistory(historyData)
       } else {

frontend/src/lib/api.ts

@@ -262,27 +262,43 @@ class ApiClient {
   async getTldHistory(tld: string, days = 90) {
     return this.request<{
       tld: string
+      type: string
+      description: string
+      registry: string
       current_price: number
       price_change_7d: number
       price_change_30d: number
       price_change_90d: number
+      trend: string
+      trend_reason: string
       history: Array<{
         date: string
         price: number
       }>
+      source: string
     }>(`/tld-prices/${tld}/history?days=${days}`)
   }
 
   async getTldCompare(tld: string) {
     return this.request<{
       tld: string
+      type: string
+      description: string
+      registry: string
+      introduced: number | null
       registrars: Array<{
         name: string
         registration_price: number
         renewal_price: number
         transfer_price: number
-        features: string[]
       }>
+      cheapest_registrar: string
+      cheapest_price: number
+      price_range: {
+        min: number
+        max: number
+        avg: number
+      }
     }>(`/tld-prices/${tld}/compare`)
   }